netdev - Re: [RFC PATCH net-next 0/8] Expose devlink port attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200603194845.3506104f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 3 Jun 2020 19:48:45 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     Danielle Ratson <danieller@...lanox.com>, netdev@...r.kernel.org,
        davem@...emloft.net, michael.chan@...adcom.com,
        jeffrey.t.kirsher@...el.com, saeedm@...lanox.com, leon@...nel.org,
        jiri@...lanox.com, idosch@...lanox.com, snelson@...sando.io,
        drivers@...sando.io, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, mlxsw@...lanox.com
Subject: Re: [RFC PATCH net-next 0/8] Expose devlink port attributes

On Wed, 3 Jun 2020 12:45:04 +0200 Jiri Pirko wrote:
> Tue, Jun 02, 2020 at 09:33:11PM CEST, kuba@...nel.org wrote:
> >On Tue,  2 Jun 2020 14:31:11 +0300 Danielle Ratson wrote:  
> >> Currently, user has no way of knowing if a port can be split and into
> >> how many ports.
> >> 
> >> Among other things, it is currently impossible to write generic tests
> >> for port split.
> >> 
> >> In order to be able to expose the information regarding the split
> >> capability to user space, set the required attributes and pass them to
> >> netlink.
> >> 
> >> Patch 1: Move set attribute from devlink_port_attrs to devlink_port.
> >> Patch 2: Move switch_port attribute from devlink_port_attrs to devlink_port
> >> Patch 3: Replace devlink_port_attrs_set parameters with a struct.
> >> Patch 4: Set and initialize lanes attribute in the driver.
> >> Patch 5: Add lanes attribute to devlink port and pass to netlink.
> >> Patch 6: Set and initialize splittable attribute in the driver.
> >> Patch 7: Add splittable attribute to devlink port and pass them to netlink.
> >> Patch 8: Add a split port test.  
> >
> >Since we have the splitability and number of lanes now understood by
> >the core - can the code also start doing more input checking?  
> 
> Yep, that should certainly be done so some of the checks can move from
> the drivers. Do you want to have this done as a part of this patchset or
> a separate one?

May be a little quicker to review if everything was done in one series,
but no strong feelings.