netdev - Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09f485dd-79ab-9978-e28a-703c9af318c2@ucloud.cn>
Date:   Wed, 1 Jul 2020 10:27:52 +0800
From:   wenxu <wenxu@...oud.cn>
To:     Eric Dumazet <eric.dumazet@...il.com>, paulb@...lanox.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after
 defrag in act_ct


On 6/30/2020 11:57 PM, Eric Dumazet wrote:
>
> On 6/29/20 7:54 PM, wenxu@...oud.cn wrote:
>> From: wenxu <wenxu@...oud.cn>
>>
>> The fragment packets do defrag in act_ct module. The reassembled packet
>> over the mtu in the act_mirred. This big packet should be fragmented
>> to send out.
>>
>> Fixes: b57dc7c13ea9 ("net/sched: Introduce action ct")
>> Signed-off-by: wenxu <wenxu@...oud.cn>
>> ---
>> This patch is based on
>> http://patchwork.ozlabs.org/project/netdev/patch/1593422178-26949-1-git-send-email-wenxu@ucloud.cn/
>>
>>  include/net/sch_generic.h |   6 +-
>>  net/sched/act_ct.c        |   7 ++-
>>  net/sched/act_mirred.c    | 157 ++++++++++++++++++++++++++++++++++++++++++++--
>>  3 files changed, 158 insertions(+), 12 deletions(-)
>>
>> diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
>> index c510b03..3597244 100644
>> --- a/include/net/sch_generic.h
>> +++ b/include/net/sch_generic.h
>> @@ -384,6 +384,7 @@ struct qdisc_skb_cb {
>>  	};
>>  #define QDISC_CB_PRIV_LEN 20
>>  	unsigned char		data[QDISC_CB_PRIV_LEN];
>> +	u16			mru;
>>  };
>>
>
> Wow, this change is potentially a big problem.
>
> Explain why act_ct/act_mirred need to pollute qdisc_skb_cb 

Hi Eric,

In the act_ct the fragment packets will defrag to a big packet and do conntrack things.

But in the latter filter mirred action, the big packet normally send over the mtu of outgoing device.

In this case the packet should be fragment to send And the frag size should based on origin frag size

recored in act_ct.  In the act_ct the frag size should retore in qdisc_skb_cb and act_mirred get it to do fragment.


So there are any other good method?


BR

wenxu 

>
>
>