netdev - Re: [PATCH iproute2-next v2 2/2] tc: implement support for terse dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d4231c5-94d2-4d14-292f-e68d015ea260@mojatatu.com>
Date:   Fri, 9 Oct 2020 08:45:21 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Vlad Buslov <vlad@...lov.dev>
Cc:     David Ahern <dsahern@...il.com>, Vlad Buslov <vladbu@...dia.com>,
        stephen@...workplumber.org, xiyou.wangcong@...il.com,
        netdev@...r.kernel.org, davem@...emloft.net, jiri@...nulli.us,
        ivecera@...hat.com, Vlad Buslov <vladbu@...lanox.com>
Subject: Re: [PATCH iproute2-next v2 2/2] tc: implement support for terse dump

On 2020-10-09 8:15 a.m., Vlad Buslov wrote:
> 
> On Fri 09 Oct 2020 at 15:03, Jamal Hadi Salim <jhs@...atatu.com> wrote:

>> Which test(s)?
>> I see for example d45e mentioning terse but i dont see corresponding
>> code in the iproute2 tree i just pulled.
> 
> Yes. The tests d45e and 7c65 were added as a part of kernel series, but
> corresponding iproute2 patches were never merged. Tests expect original
> "terse flag" syntax of V1 iproute2 series and will have to be changed to
> use -brief option instead.

Then i dont see a problem in changing the tests.
If you are going to send a v3 please include my acked-by.
Would have been nice to see what terse output would have looked like.

cheers,
jamal