netdev - Re: [PATCH v1] can: mcp251xfd: Add some sysfs debug interfaces for registers r/w

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Jan 2021 16:04:21 +0800
From:   Su <suyanjun218@...il.com>
To:     Marc Kleine-Budde <mkl@...gutronix.de>,
        manivannan.sadhasivam@...aro.org, thomas.kopp@...rochip.com,
        wg@...ndegger.com, davem@...emloft.net, kuba@...nel.org,
        lgirdwood@...il.com, broonie@...nel.org
Cc:     linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] can: mcp251xfd: Add some sysfs debug interfaces for
 registers r/w


在 2021/1/22 下午3:22, Marc Kleine-Budde 写道:
> On 1/22/21 7:22 AM, Su Yanjun wrote:
>> When i debug mcp2518fd, some method to track registers is
>> needed. This easy debug interface will be ok.
> NACK
>
> As the driver uses regmap, everything should be there already.
>
> To read use:
>
> | cat /sys/kernel/debug/regmap/spi0.0-crc/registers
>
> Register write support for devices that are handles by proper kernel drivers is
> a pure debugging tool, thus not enabled by default, not even with a Kconfig
> switch. You have to enable it manually, have a look at commit:
>
> 09c6ecd39410 regmap: Add support for writing to regmap registers via debugfs

You're right.

Thank you

>
> regards,
> Marc
>