netdev - Re: [PATCH net-next] ethtool: add missing EEPROM to list of messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YH357QLGqz6igLtc@lunn.ch>
Date:   Mon, 19 Apr 2021 23:45:17 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, mkubecek@...e.cz,
        corbet@....net, vladyslavt@...dia.com, linux-doc@...r.kernel.org
Subject: Re: [PATCH net-next] ethtool: add missing EEPROM to list of messages

On Mon, Apr 19, 2021 at 02:26:22PM -0700, Jakub Kicinski wrote:
> ETHTOOL_MSG_MODULE_EEPROM_GET is missing from the list of messages.
> ETHTOOL_MSG_MODULE_EEPROM_GET_REPLY is sadly a rather long name
> so we need to adjust column length.
> 
> Fixes: c781ff12a2f3 ("ethtool: Allow network drivers to dump arbitrary EEPROM data")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  Documentation/networking/ethtool-netlink.rst | 70 ++++++++++----------
>  1 file changed, 36 insertions(+), 34 deletions(-)
> 
> diff --git a/Documentation/networking/ethtool-netlink.rst b/Documentation/networking/ethtool-netlink.rst
> index 48cad2fce147..c8814d787072 100644
> --- a/Documentation/networking/ethtool-netlink.rst
> +++ b/Documentation/networking/ethtool-netlink.rst
> @@ -210,45 +210,47 @@ All constants identifying message types use ``ETHTOOL_CMD_`` prefix and suffix
>    ``ETHTOOL_MSG_TUNNEL_INFO_GET``       get tunnel offload info
>    ``ETHTOOL_MSG_FEC_GET``               get FEC settings
>    ``ETHTOOL_MSG_FEC_SET``               set FEC settings
> +  ``ETHTOOL_MSG_MODULE_EEPROM_GET``	read SFP module EEPROM

It looks like you used a tab, where as the rest of the table is
spaces?

	Andrew