netdev - Re: [PATCH net-next] ethtool: add missing EEPROM to list of messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210419145049.2ab6edd7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 19 Apr 2021 14:50:49 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, mkubecek@...e.cz,
        corbet@....net, vladyslavt@...dia.com, linux-doc@...r.kernel.org
Subject: Re: [PATCH net-next] ethtool: add missing EEPROM to list of
 messages

On Mon, 19 Apr 2021 23:45:17 +0200 Andrew Lunn wrote:
> > @@ -210,45 +210,47 @@ All constants identifying message types use ``ETHTOOL_CMD_`` prefix and suffix
> >    ``ETHTOOL_MSG_TUNNEL_INFO_GET``       get tunnel offload info
> >    ``ETHTOOL_MSG_FEC_GET``               get FEC settings
> >    ``ETHTOOL_MSG_FEC_SET``               set FEC settings
> > +  ``ETHTOOL_MSG_MODULE_EEPROM_GET``	read SFP module EEPROM  
> 
> It looks like you used a tab, where as the rest of the table is
> spaces?

Ah.. after carefully adjusting _REPLY to use spaces.. :)
Sorry, v2 coming.