netdev - Re: [PATCH v2] tcp: fix tp->undo_retrans accounting in tcp_sacktag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADVnQykB6SPrY8Ov+A6Uu0YqaaX2wS5_kHWkWGqKyX6cUGfC9g@mail.gmail.com>
Date:   Fri, 10 Sep 2021 09:49:29 -0400
From:   Neal Cardwell <ncardwell@...gle.com>
To:     zhenggy <zhenggy@...natelecom.cn>
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, davem@...emloft.net,
        yoshfuji@...ux-ipv6.org, dsahern@...nel.org, kuba@...nel.org,
        ycheng@...gle.com
Subject: Re: [PATCH v2] tcp: fix tp->undo_retrans accounting in tcp_sacktag_one()

On Thu, Sep 9, 2021 at 10:40 PM zhenggy <zhenggy@...natelecom.cn> wrote:
>
> Commit a71d77e6be1e ("tcp: fix segment accounting when DSACK range covers
> multiple segments") fix some DSACK accounting for multiple segments.
> In tcp_sacktag_one(), we should also use the actual DSACK rang(pcount)

nit: typo; I'd suggest: "range (pcount)"

> for tp->undo_retrans accounting.
>
> Fixes: 10d3be569243 ("tcp-tso: do not split TSO packets at retransmit time")
>
> Before that commit, the assumption underlying the tp->undo_retrans--
> seems correct, AFAICT.
>
> Signed-off-by: zhenggy <zhenggy@...natelecom.cn>

Please take a look at the standard formatting in the "git log"
history. The Fixes: tag should be in the footers section, typically
the first footer, preceding fields like Reported-by: and Cc: and
Signed-off-by:.

Please consider something like:

----
Since 10d3be569243 ("tcp-tso: do not split TSO packets at retransmit time")
this logic can no longer assume that a retransmitted packet is a single segment.

Fixes: 10d3be569243 ("tcp-tso: do not split TSO packets at retransmit time")
Signed-off-by: zhenggy <zhenggy@...natelecom.cn>
---

thanks,
neal