netdev - Re: [PATCH net-next 2/3] net: dsa: sja1105: fix broken connection with the sja1110 tagger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <701ea34d-d94c-9ea7-16dc-eb066e71780f@gmail.com>
Date:   Mon, 13 Dec 2021 20:34:49 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Ansuel Smith <ansuelsmth@...il.com>
Subject: Re: [PATCH net-next 2/3] net: dsa: sja1105: fix broken connection
 with the sja1110 tagger



On 12/13/2021 5:45 PM, Vladimir Oltean wrote:
> The driver was incorrectly converted assuming that "sja1105" is the only
> tagger supported by this driver. This results in SJA1110 switches
> failing to probe:
> 
> sja1105 spi1.0: Unable to connect to tag protocol "sja1110": -EPROTONOSUPPORT
> sja1105: probe of spi1.2 failed with error -93
> 
> Add DSA_TAG_PROTO_SJA1110 to the list of supported taggers by the
> sja1105 driver. The sja1105_tagger_data structure format is common for
> the two tagging protocols.
> 
> Fixes: c79e84866d2a ("net: dsa: tag_sja1105: convert to tagger-owned data")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian