netdev - Re: [PATCH v2 2/2] net: axiemac: use a phandle to reference pcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABgGipUVMBW8yZum60MUKsni-kNQf-P0HW7-2NVT9mR=c2dNRA@mail.gmail.com>
Date:   Thu, 17 Mar 2022 17:52:44 +0800
From:   Andy Chiu <andy.chiu@...ive.com>
To:     davem@...emloft.net, kuba@...nel.org, michal.simek@...inx.com,
        linux@...linux.org.uk, Robert Hancock <robert.hancock@...ian.com>,
        andrew@...n.ch, netdev@...r.kernel.org, devicetree@...r.kernel.org,
        radhey.shyam.pandey@...inx.com
Cc:     Greentime Hu <greentime.hu@...ive.com>
Subject: Re: [PATCH v2 2/2] net: axiemac: use a phandle to reference pcs_phy

loop in: radhey.shyam.pandey@...inx.com

I am sending this out since I forgot to CC the maintainer of the
driver, again...

Sorry for being noisy here.

Regards,
Andy


On Thu, Mar 17, 2022 at 5:21 PM Andy Chiu <andy.chiu@...ive.com> wrote:
>
> In some SGMII use cases where both an external PHY and the internal
> PCS/PMA PHY need to be configured, we should explicitly use a phandle
> "pcs-phy" to get the reference to the PCS/PMA PHY. Otherwise, the driver
> would use "phy-handle" in the DT as the reference to both external and
> the internal PCS/PMA PHY.
>
> In other cases where the core is connected to a SFP cage, we could
> fallback, pointing phy-handle to the intenal PCS/PMA PHY, and let the
> driver connect to the SFP module, if exist, via phylink.
>
> Fixes: 1a02556086fc (net: axienet: Properly handle PCS/PMA PHY for 1000BaseX mode)
> Signed-off-by: Andy Chiu <andy.chiu@...ive.com>
> Reviewed-by: Greentime Hu <greentime.hu@...ive.com>
> ---
>  drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index 6fd5157f0a6d..17de81cc0ca5 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -2078,7 +2078,13 @@ static int axienet_probe(struct platform_device *pdev)
>                         ret = -EINVAL;
>                         goto cleanup_mdio;
>                 }
> -               lp->pcs_phy = of_mdio_find_device(lp->phy_node);
> +               np = of_parse_phandle(pdev->dev.of_node, "pcs-handle", 0);
> +               if (np) {
> +                       lp->pcs_phy = of_mdio_find_device(np);
> +                       of_node_put(np);
> +               } else {
> +                       lp->pcs_phy = of_mdio_find_device(lp->phy_node);
> +               }
>                 if (!lp->pcs_phy) {
>                         ret = -EPROBE_DEFER;
>                         goto cleanup_mdio;
> --
> 2.34.1
>