netdev - Re: [EXT] Re: [PATCH net-next] sandlan: Add the sandlan virtual network interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4f07c0cb42ce191e8054fe816e7b8295425a16f2.camel@inf.elte.hu>
Date:   Tue, 21 Feb 2023 11:19:07 +0100
From:   Ferenc Fejes <fejes@....elte.hu>
To:     Steve Williams <steve.williams@...cruise.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [EXT] Re: [PATCH net-next] sandlan: Add the sandlan virtual
 network interface

Hi Steve!

On Tue, 2022-11-29 at 09:54 -0800, Steve Williams wrote:
> On Tue, Nov 22, 2022 at 12:09 PM Andrew Lunn <andrew@...n.ch> wrote:
> > 
> > On Mon, Nov 21, 2022 at 06:59:11PM -0800, Steve Williams wrote:
> > > I have had trouble with the veth driver not transparently passing
> > > the
> > > full ethernet packets unaltered, and this is wreaking havoc with
> > > the
> > > hanic driver that I have (and that I'm submitting separately).
> > > That,
> > > and veth nodes only come in pairs, whereas with sandlan I can
> > > make
> > > more complex LANs and that allows me to emulate more complex
> > > situations. But fair point, and I am looking more closely at
> > > figuring
> > > out exactly what the veth driver is doing to my packets.
> > 
> > If there is a real problem with veth, please describe it, so we can
> > fix the bugs. We don't add new emulators because of bugs in the
> > existing system.
> 
> In light of the feedback I received here, I revisited the issue; and
> was able to get the veth driver to work after all, at least for
> regression tests of the hanic driver. I can't seem to reproduce the
> issue I thought I was having. So that kills one motivation for the
> sandlan driver, at least for me.

Good to know. I noticed your sandlan/hanic patches just now, and just
also wanted to tell that veth good enough for pretty much all 802.1CB
use-cases I'm aware of. In fact I use 2 veth paris in my .1CB testings
as well.

> 
> -- 
> 
> Stephen Williams
> 
> Senior Software Engineer
> 
> Cruise
> 


Best,
Ferenc