netdev - Re: [PATCHv2 net 0/2] net/sched: fix parsing of TCA_EXT_WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoMkytZ26ZafxKBG3-EpXow_nWyrxye18Prr8JQ-VTVovpg@mail.gmail.com>
Date:   Thu, 16 Mar 2023 05:45:28 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        David Ahern <dsahern@...nel.org>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Davide Caratti <dcaratti@...hat.com>,
        Pedro Tammela <pctammela@...atatu.com>,
        Marcelo Leitner <mleitner@...hat.com>,
        Phil Sutter <psutter@...hat.com>
Subject: Re: [PATCHv2 net 0/2] net/sched: fix parsing of TCA_EXT_WARN_MSG for
 tc action

On Wed, Mar 15, 2023 at 11:55 PM Hangbin Liu <liuhangbin@...il.com> wrote:
>
> On Thu, Mar 16, 2023 at 11:37:51AM +0800, Hangbin Liu wrote:
> > In my previous commit 0349b8779cc9 ("sched: add new attr TCA_EXT_WARN_MSG
> > to report tc extact message") I didn't notice the tc action use different
> > enum with filter. So we can't use TCA_EXT_WARN_MSG directly for tc action.
> >
> > Let's rever the previous fix 923b2e30dc9c ("net/sched: act_api: move
> > TCA_EXT_WARN_MSG to the correct hierarchy") and add a new
> > TCA_ROOT_EXT_WARN_MSG for tc action specifically.
>
> Sigh. Sorry I sent the mail too quick and forgot to add
>
> Reported-and-tested-by: Davide Caratti <dcaratti@...hat.com>

For next time: instead of saying in the commit message "suggested by
foo" specify it using "suggested-by: foo" semantics.

cheers,
jamal