netdev - Re: [PATCH net-next 2/2] net: pcs: lynx: don't print an_enabled in pcs_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27ba7f8d0d1694b792a917bf5d9d9d8e9047686a.camel@microchip.com>
Date:   Thu, 16 Mar 2023 10:45:40 +0100
From:   Steen Hegelund <steen.hegelund@...rochip.com>
To:     "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Jonathan McDowell <noodles@...th.li>,
        Jose Abreu <Jose.Abreu@...opsys.com>,
        Vladimir Oltean <olteanv@...il.com>
CC:     Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: pcs: lynx: don't print an_enabled in
 pcs_get_state()

Hi Russell,

On Wed, 2023-03-15 at 14:46 +0000, Russell King (Oracle) wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> an_enabled will be going away, and in any case, pcs_get_state() should
> not be updating this member. Remove the print.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---
>  drivers/net/pcs/pcs-lynx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/pcs/pcs-lynx.c b/drivers/net/pcs/pcs-lynx.c
> index 3903f3baba2b..622c3de3f3a8 100644
> --- a/drivers/net/pcs/pcs-lynx.c
> +++ b/drivers/net/pcs/pcs-lynx.c
> @@ -112,11 +112,11 @@ static void lynx_pcs_get_state(struct phylink_pcs *pcs,
>         }
> 
>         dev_dbg(&lynx->mdio->dev,
> -               "mode=%s/%s/%s link=%u an_enabled=%u an_complete=%u\n",
> +               "mode=%s/%s/%s link=%u an_complete=%u\n",
>                 phy_modes(state->interface),
>                 phy_speed_to_str(state->speed),
>                 phy_duplex_to_str(state->duplex),
> -               state->link, state->an_enabled, state->an_complete);
> +               state->link, state->an_complete);
>  }
> 
>  static int lynx_pcs_config_giga(struct mdio_device *pcs, unsigned int mode,
> --
> 2.30.2
> 

Reviewed-by: Steen Hegelund <Steen.Hegelund@...rochip.com>

BR
Steen