netdev - Re: [PATCH net-next] net: stmmac: propagate feature flags to vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230412211513.2d6fc1f7@kernel.org>
Date:   Wed, 12 Apr 2023 21:15:13 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Corinna Vinschen <vinschen@...hat.com>
Cc:     netdev@...r.kernel.org,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        alexandre.torgue@...s.st.com, Jose Abreu <joabreu@...opsys.com>
Subject: Re: [PATCH net-next] net: stmmac: propagate feature flags to vlan

On Tue, 11 Apr 2023 15:00:28 +0200 Corinna Vinschen wrote:
> stmmac_dev_probe doesn't propagate feature flags to VLANs.  So features
> like TX offloading don't correspond with the general features and it's
> not possible to manipulate features via ethtool -K to affect VLANs.

Actually, could you add to the commit message a sentence or two about
the features that you tested and/or a mention of the manual indicating
that they are supported over vlans? Especially TSO on a quick look.
I just realized now that you didn't explicitly say that those features
work, just that you can manipulate them...