netdev - Re: [PATCH net-next v2 2/3] i40e: remove unnecessary check for old MAC == new MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 13 Jun 2023 15:11:40 +0200
From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
To: Piotr Gardocki <piotrx.gardocki@...el.com>
CC: <netdev@...r.kernel.org>, <intel-wired-lan@...ts.osuosl.org>,
	<przemyslaw.kitszel@...el.com>, <michal.swiatkowski@...ux.intel.com>,
	<pmenzel@...gen.mpg.de>, <kuba@...nel.org>, <anthony.l.nguyen@...el.com>,
	<simon.horman@...igine.com>, <aleksander.lobakin@...el.com>
Subject: Re: [PATCH net-next v2 2/3] i40e: remove unnecessary check for old
 MAC == new MAC

On Tue, Jun 13, 2023 at 02:24:19PM +0200, Piotr Gardocki wrote:
> The check has been moved to core. The ndo_set_mac_address callback
> is not being called with new MAC address equal to the old one anymore.
> 
> Signed-off-by: Piotr Gardocki <piotrx.gardocki@...el.com>

Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>

> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index b847bd105b16..29ad1797adce 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -1788,12 +1788,6 @@ static int i40e_set_mac(struct net_device *netdev, void *p)
>  	if (!is_valid_ether_addr(addr->sa_data))
>  		return -EADDRNOTAVAIL;
>  
> -	if (ether_addr_equal(netdev->dev_addr, addr->sa_data)) {
> -		netdev_info(netdev, "already using mac address %pM\n",
> -			    addr->sa_data);
> -		return 0;
> -	}
> -
>  	if (test_bit(__I40E_DOWN, pf->state) ||
>  	    test_bit(__I40E_RESET_RECOVERY_PENDING, pf->state))
>  		return -EADDRNOTAVAIL;
> -- 
> 2.34.1
>