netdev - Re: [PATCH net-next v6 3/5] rust: add second `bindgen` pass for enum exhaustiveness checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6412a54b-844a-497c-a7e2-2b5f94005226@proton.me>
Date: Tue, 24 Oct 2023 16:29:16 +0000
From: Benno Lossin <benno.lossin@...ton.me>
To: FUJITA Tomonori <fujita.tomonori@...il.com>, netdev@...r.kernel.org
Cc: rust-for-linux@...r.kernel.org, andrew@...n.ch, tmgross@...ch.edu, miguel.ojeda.sandonis@...il.com, wedsonaf@...il.com, greg@...ah.com, Miguel Ojeda <ojeda@...nel.org>
Subject: Re: [PATCH net-next v6 3/5] rust: add second `bindgen` pass for enum exhaustiveness checking

On 24.10.23 02:58, FUJITA Tomonori wrote:
> From: Miguel Ojeda <ojeda@...nel.org>

I think this commit message should also explain what it is
doing and not only the error below.

-- 
Cheers,
Benno

>      error[E0005]: refutable pattern in function argument
>           --> rust/bindings/bindings_enum_check.rs:29:6
>            |
>      29    |       (phy_state::PHY_DOWN
>            |  ______^
>      30    | |     | phy_state::PHY_READY
>      31    | |     | phy_state::PHY_HALTED
>      32    | |     | phy_state::PHY_ERROR
>      ...     |
>      35    | |     | phy_state::PHY_NOLINK
>      36    | |     | phy_state::PHY_CABLETEST): phy_state,
>            | |______________________________^ pattern `phy_state::PHY_NEW` not covered
>            |
>      note: `phy_state` defined here
>           --> rust/bindings/bindings_generated_enum_check.rs:60739:10
>            |
>      60739 | pub enum phy_state {
>            |          ^^^^^^^^^
>      ...
>      60745 |     PHY_NEW = 5,
>            |     ------- not covered
>            = note: the matched value is of type `phy_state`
> 
> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@...il.com>
> ---

[...]