netdev - Re: [RFC net-next 3/5] net: dsa: realtek: create realtek-common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <gy4k3p2b7n4urwpdvl2x6dwmyyb6rcjvzxhi5gggn3hn7n66ab@2g5hwu732644>
Date: Mon, 13 Nov 2023 22:01:14 +0000
From: Alvin Šipraga <ALSI@...g-olufsen.dk>
To: Luiz Angelo Daros de Luca <luizluca@...il.com>
CC: Linus Walleij <linus.walleij@...aro.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "andrew@...n.ch" <andrew@...n.ch>,
	"vivien.didelot@...il.com" <vivien.didelot@...il.com>, "f.fainelli@...il.com"
	<f.fainelli@...il.com>, "olteanv@...il.com" <olteanv@...il.com>,
	"davem@...emloft.net" <davem@...emloft.net>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "arinc.unal@...nc9.com" <arinc.unal@...nc9.com>
Subject: Re: [RFC net-next 3/5] net: dsa: realtek: create realtek-common

Hi Luiz,

On Mon, Nov 13, 2023 at 05:41:49PM -0300, Luiz Angelo Daros de Luca wrote:
> > > Some code can be shared between both interface modules (MDIO and SMI)
> > > and amongst variants. For now, these interface functions are shared:
> > >
> > > - realtek_common_lock
> > > - realtek_common_unlock
> > > - realtek_common_probe
> > > - realtek_common_remove
> > >
> > > The reset during probe was moved to the last moment before a variant
> > > detects the switch. This way, we avoid a reset if anything else fails.
> > >
> > > The symbols from variants used in of_match_table are now in a single
> > > match table in realtek-common, used by both interfaces.
> > >
> > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@...il.com>
> >
> > As Krzysztof explained the dev_err_probe() call already prints
> > ret. With that fixed:
> > Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> 
> Thanks Krzysztof and Linus. I'll be fixed.
> 
> Is it ok to keep the series as a whole or should I split it?

I would prefer that you split it and send the realtek-common series first.
My 2c.

Sorry for not reviewing yet but I'll take a look tomorrow. Cheers!

Kind regards,
Alvin