| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Nov 2023 14:03:00 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: Andrew Lunn <andrew@...n.ch>, Fabio Estevam <festevam@...il.com> Cc: kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, netdev@...r.kernel.org, devicetree@...r.kernel.org, Fabio Estevam <festevam@...x.de> Subject: Re: [PATCH net-next] dt-bindings: net: snps,dwmac: Do not make 'phy-mode' required On 11/13/23 13:51, Andrew Lunn wrote: > On Mon, Nov 13, 2023 at 05:40:52PM -0300, Fabio Estevam wrote: >> From: Fabio Estevam <festevam@...x.de> >> >> The property 'phy-connection-type' can also be used to describe >> the interface type between the Ethernet device and the Ethernet PHY >> device. >> >> Mark 'phy-mode' as a non required property. > > Hi Fabio > > What does the driver actually require? Will it error out if neither is > provided? > > Maybe we should be changing the condition that one or the other is > required? 'phy-connection-type' is the deprecated version of 'phy-mode' which of_get_phy_mode() will fall back to if 'phy-mode' is not provided. It does not appear that stmmac attempts to use anything other than of_get_phy_mode() therefore would not it be acceptable to update the relevant .dts file such that it uses 'phy-mode'? That really should not have a functional impact given that of_get_phy_mode() has worked that way for a while. -- Florian
Powered by blists - more mailing lists