netdev - Re: [PATCH net-next v11 4/6] net: stmmac: dwmac-loongson: Introduce GMAC setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96d06fdc-8326-4394-a0e3-b1f98590deb7@loongson.cn>
Date: Fri, 19 Apr 2024 18:06:48 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: Serge Semin <fancer.lancer@...il.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com, Jose.Abreu@...opsys.com,
 chenhuacai@...nel.org, linux@...linux.org.uk, guyinggang@...ngson.cn,
 netdev@...r.kernel.org, chris.chenfeiyang@...il.com, siyanteng01@...il.com
Subject: Re: [PATCH net-next v11 4/6] net: stmmac: dwmac-loongson: Introduce
 GMAC setup


在 2024/4/18 20:26, Serge Semin 写道:
>>   	plat->multicast_filter_bins = 256;
>> +	plat->clk_ref_rate = 125000000;
>> +	plat->clk_ptp_rate = 125000000;
> This change is unrelated to the rest of the changes in this patch.
> Please split the patch up into two:
> 1. Add ref and ptp clocks for Loongson GMAC
> 2. Split up the platform data initialization
> First one is a new feature adding the actual ref clock rates to the
> driver. The second patch is a preparation before adding the full PCI
> support.
>
Ok, but we need to reverse the order:

1. Split up the platform data initialization

2. Add ref and ptp clocks for Loongson GMAC


Since loongson_gmac_data() needs to be introduced first, then we can add the

clock rates of GMAC.


Thanks,
Yanteng