netdev - Re: [PATCH net-next v11 5/6] net: stmmac: dwmac-loongson: Add full PCI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1abf101b-87b8-448a-bd2a-bc9fb7c28852@loongson.cn>
Date: Sat, 20 Apr 2024 10:41:24 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: Serge Semin <fancer.lancer@...il.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com, Jose.Abreu@...opsys.com,
 chenhuacai@...nel.org, linux@...linux.org.uk, guyinggang@...ngson.cn,
 netdev@...r.kernel.org, chris.chenfeiyang@...il.com, siyanteng01@...il.com
Subject: Re: [PATCH net-next v11 5/6] net: stmmac: dwmac-loongson: Add full
 PCI support


在 2024/4/18 21:08, Serge Semin 写道:
>> -	np = dev_of_node(&pdev->dev);
>> -
>> -	if (!np) {
>> -		pr_info("dwmac_loongson_pci: No OF node\n");
>> -		return -ENODEV;
>> -	}
> Hm, I see you dropping this snippet and never getting it back in this
> patch. Thus after the patch is applied np will be left uninitialized,
> which will completely break the driver. Please make sure it's fixed.
>
> This problem has been introduced at the v9 stage, which I didn't have
> time to review. There were no problem like that in v8.

Okay, I will restore it.


Thanks,

Yanteng