netdev - Re: [PATCH net-next v11 6/6] net: stmmac: dwmac-loongson: Add Loongson GNET support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <932e5719-66d1-446d-b67c-4c87b00d63b0@loongson.cn>
Date: Sun, 21 Apr 2024 13:35:15 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: Serge Semin <fancer.lancer@...il.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com, Jose.Abreu@...opsys.com,
 chenhuacai@...nel.org, linux@...linux.org.uk, guyinggang@...ngson.cn,
 netdev@...r.kernel.org, chris.chenfeiyang@...il.com, siyanteng01@...il.com
Subject: Re: [PATCH net-next v11 6/6] net: stmmac: dwmac-loongson: Add
 Loongson GNET support


在 2024/4/20 19:02, Yanteng Si 写道:
>>> - memset(&res, 0, sizeof(res));
>>> -    res.addr = pcim_iomap_table(pdev)[0];
>>> +    /* GNET devices with dev revision 0x00 do not support manually
>>> +     * setting the speed to 1000.
>>> +     */
>>> +    if (pdev->device == PCI_DEVICE_ID_LOONGSON_GNET &&
>>> +        pdev->revision == 0x00)
>>> +        plat->flags |= STMMAC_FLAG_DISABLE_FORCE_1000;
>> Move this to the loongson_gnet_data() method.
> Okay, But I noticed your comment at the end that we need to splite as a
>
> separate _pre-requisite/preparation_ patch, this fix is for gnet 
> devices, there is no gnet at this time. So, if I understand you 
> correctly, we should need two patches: net: stmmac: dwmac-loongson: 
> Disable force 1000 net: stmmac: dwmac-loongson: Add Loongson GNET 
> support net: stmmac: dwmac-loongson:  Move DISABLE_FORCE_1000 flag to 
> loongson_gnet_data() method

Sorry, my email client messed things up.

Okay, But I noticed your comment at the end that we need to splite as a

separate _pre-requisite/preparation_ patch, this fix is for gnet devices,

there is no gnet at this time. So, if I understand you correctly, we should

need two new patches:

++ net: stmmac: dwmac-loongson: Disable force 1000

     net: stmmac: dwmac-loongson: Add Loongson GNET support

++ net: stmmac: dwmac-loongson:  Move DISABLE_FORCE_1000 flag to 
loongson_gnet_data() method


Thanks,

Yanteng