netdev - Re: [PATCH net-next v11 4/6] net: stmmac: dwmac-loongson: Introduce GMAC setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b918781-05bc-4d79-8d5d-52692e773706@loongson.cn>
Date: Mon, 22 Apr 2024 18:17:32 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com, fancer.lancer@...il.com
Cc: Jose.Abreu@...opsys.com, chenhuacai@...nel.org, linux@...linux.org.uk,
 guyinggang@...ngson.cn, netdev@...r.kernel.org, chris.chenfeiyang@...il.com,
 siyanteng01@...il.com
Subject: Re: [PATCH net-next v11 4/6] net: stmmac: dwmac-loongson: Introduce
 GMAC setup

Hi all

在 2024/4/12 19:28, Yanteng Si 写道:
> @@ -42,6 +45,12 @@ static int loongson_default_data(struct plat_stmmacenet_data *plat)
>   	plat->dma_cfg->pblx8 = true;
>   
>   	plat->multicast_filter_bins = 256;
> +	plat->clk_ref_rate = 125000000;
> +	plat->clk_ptp_rate = 125000000;
> +

> +	plat->tx_queues_to_use = 1;
> +	plat->rx_queues_to_use = 1;

Sorry, I forgot to delete them.

This part of the code has been moved to loongson_dwmac_probe() in this 
patch set, Why?

Because we have two different gnet devices: the 2k2000 supports multiple 
channels,

the 7a2000 only supports single channels, and all GMAC devices only 
support single channels.

If we keep this part of the code here, we will get GMAC_VERSION again in 
gnet_data()

  to distinguish them, which will make the code more complex. We can use 
GMAC_VERSION

in probe to distinguish them easily.

  so the patch will be redesigned in v12.

Thanks,

Yanteng