netdev - Re: [PATCHv2 net-next] ipv6: sr: restruct ifdefines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87566a43-6cae-4bc9-98ca-793d6aba92b2@kernel.org>
Date: Wed, 29 May 2024 09:27:36 -0600
From: David Ahern <dsahern@...nel.org>
To: Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Vasiliy Kovalev <kovalev@...linux.org>,
 Sabrina Dubroca <sd@...asysnail.net>, Guillaume Nault <gnault@...hat.com>,
 Simon Horman <horms@...nel.org>, David Lebrun <david.lebrun@...ouvain.be>
Subject: Re: [PATCHv2 net-next] ipv6: sr: restruct ifdefines

On 5/28/24 10:09 PM, Hangbin Liu wrote:
> There are too many ifdef in IPv6 segment routing code that may cause logic
> problems. like commit 160e9d275218 ("ipv6: sr: fix invalid unregister error
> path"). To avoid this, the init functions are redefined for both cases. The
> code could be more clear after all fidefs are removed.
> 
> Suggested-by: Simon Horman <horms@...nel.org>
> Suggested-by: David Ahern <dsahern@...nel.org>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
> v2: add a new label to call seg6_iptunnel_exit directly (Sabrina Dubroca)
>     add suggested-by tag (Sabrina Dubroca)
> ---
>  include/net/seg6.h      |  7 +++++++
>  include/net/seg6_hmac.h |  7 +++++++
>  net/ipv6/seg6.c         | 33 +++++----------------------------
>  3 files changed, 19 insertions(+), 28 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>

Thanks for the followup; looks much cleaner to me.