netdev - Re: [PATCH net-next] net: tn40xx: add initial ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 28 Jun 2024 16:14:44 +0200
From: Andrew Lunn <andrew@...n.ch>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, linux@...linux.org.uk
Subject: Re: [PATCH net-next] net: tn40xx: add initial ethtool_ops support

On Fri, Jun 28, 2024 at 10:41:16PM +0900, FUJITA Tomonori wrote:
> Call phylink_ethtool_ksettings_get() for get_link_ksettings method and
> ethtool_op_get_link() for get_link method.
> 
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@...il.com>
> ---
>  drivers/net/ethernet/tehuti/tn40.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/net/ethernet/tehuti/tn40.c b/drivers/net/ethernet/tehuti/tn40.c
> index 11db9fde11fe..565b72537efa 100644
> --- a/drivers/net/ethernet/tehuti/tn40.c
> +++ b/drivers/net/ethernet/tehuti/tn40.c
> @@ -1571,6 +1571,19 @@ static const struct net_device_ops tn40_netdev_ops = {
>  	.ndo_vlan_rx_kill_vid = tn40_vlan_rx_kill_vid,
>  };
>  
> +static int tn40_ethtool_get_link_ksettings(struct net_device *ndev,
> +					   struct ethtool_link_ksettings *cmd)
> +{
> +	struct tn40_priv *priv = netdev_priv(ndev);
> +
> +	return phylink_ethtool_ksettings_get(priv->phylink, cmd);
> +}

Have you tried implementing tn40_ethtool_set_link_ksettings() in the
same way?

This patch is however O.K. as is:

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew