[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240628.232952.860169904679046997.fujita.tomonori@gmail.com>
Date: Fri, 28 Jun 2024 23:29:52 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: andrew@...n.ch
Cc: fujita.tomonori@...il.com, netdev@...r.kernel.org, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
linux@...linux.org.uk
Subject: Re: [PATCH net-next] net: tn40xx: add initial ethtool_ops support
On Fri, 28 Jun 2024 16:14:44 +0200
Andrew Lunn <andrew@...n.ch> wrote:
>> +static int tn40_ethtool_get_link_ksettings(struct net_device *ndev,
>> + struct ethtool_link_ksettings *cmd)
>> +{
>> + struct tn40_priv *priv = netdev_priv(ndev);
>> +
>> + return phylink_ethtool_ksettings_get(priv->phylink, cmd);
>> +}
>
> Have you tried implementing tn40_ethtool_set_link_ksettings() in the
> same way?
Not yet. I'll try. The original driver doesn't support
ethtool_set_link_ksettings().
> This patch is however O.K. as is:
>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
Thanks!
Powered by blists - more mailing lists