netdev - Re: [PATCH v3 02/12] netlink: spec: add shaper YAML spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zqy7hU0pBGoXBKQY@nanopsycho.orion>
Date: Fri, 2 Aug 2024 12:57:09 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Donald Hunter <donald.hunter@...il.com>, netdev@...r.kernel.org,
	Jakub Kicinski <kuba@...nel.org>,
	Madhu Chittim <madhu.chittim@...el.com>,
	Sridhar Samudrala <sridhar.samudrala@...el.com>,
	Simon Horman <horms@...nel.org>,
	John Fastabend <john.fastabend@...il.com>,
	Sunil Kovvuri Goutham <sgoutham@...vell.com>,
	Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH v3 02/12] netlink: spec: add shaper YAML spec

Thu, Aug 01, 2024 at 04:31:04PM CEST, pabeni@...hat.com wrote:
>On 7/31/24 23:13, Donald Hunter wrote:
>> Paolo Abeni <pabeni@...hat.com> writes:
>> 
>> > diff --git a/Documentation/netlink/specs/shaper.yaml b/Documentation/netlink/specs/shaper.yaml
>> > new file mode 100644
>> > index 000000000000..7327f5596fdb
>> > --- /dev/null
>> > +++ b/Documentation/netlink/specs/shaper.yaml
>> 
>> It's probably more user-friendly to use the same filename as the spec
>> name, so net-shaper.yaml
>
>No big objection on my side, but if we enforce 'Name:' to be $(basename $file
>.yaml), the 'Name' field becomes redundant.

I agree with Donald, better to stay consistent.


>
>[...]
>> > +    render-max: true
>> > +    entries:
>> > +      - name: unspec
>> > +        doc: The scope is not specified
>> 
>> What are the semantics of 'unspec' ? When can it be used?
>
>I guess at this point it can be dropped. It was introduced in a previous
>incarnation to represent the port parent - the port does not have a parent,
>being the root of the hierarchy.
>
>> > +      -
>> > +        name: port
>> > +        doc: The root for the whole H/W
>> > +      -
>> > +        name: netdev
>> > +        doc: The main shaper for the given network device.
>> 
>> What are the semantic differences between netdev and port?

I'm happy that I'm not the only one in the dark :)


>
>netdev == Linux network device
>port == wire plug
>
>> > +      -
>> > +        name: queue
>> > +        doc: The shaper is attached to the given device queue.
>> > +      -
>> > +        name: detached
>> > +        doc: |
>> > +             The shaper is not attached to any user-visible network
>> > +             device component and allows nesting and grouping of
>> > +             queues or others detached shapers.
>> 
>> I assume that shapers are always owned by the netdev regardless of
>> attach status?

But is it a "status"? It is a scope, can't change. I see you probably
got the same confusion as I got, expecting that this can be attached
somehow.


>
>If you mean that it's up to the netdev clean them up on (netdev) removal,
>yes.
>

[...]