netdev - Re: [PATCH v3 02/12] netlink: spec: add shaper YAML spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZqzA3rbIJmGjzIlU@nanopsycho.orion>
Date: Fri, 2 Aug 2024 13:19:58 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
	Madhu Chittim <madhu.chittim@...el.com>,
	Sridhar Samudrala <sridhar.samudrala@...el.com>,
	Simon Horman <horms@...nel.org>,
	John Fastabend <john.fastabend@...il.com>,
	Sunil Kovvuri Goutham <sgoutham@...vell.com>,
	Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH v3 02/12] netlink: spec: add shaper YAML spec

Tue, Jul 30, 2024 at 10:39:45PM CEST, pabeni@...hat.com wrote:

[...]


>+      -
>+        name: inputs
>+        type: nest
>+        multi-attr: true
>+        nested-attributes: ns-info

Hmm, you sometimes use this "ns-" prefix. Why? Does it mean
"net-shaper"?

This results to:
net_shaper_ns_info_nl_policy

Wouldn't it be better to name it just "info":
net_shaper_info_nl_policy

And for ns-output-info, just "output-info":
net_shaper_output_info_nl_policy

?


>+        doc: |
>+           Describes a set of inputs shapers for a @group operation
>+      -
>+        name: output
>+        type: nest
>+        nested-attributes: ns-output-info
>+        doc: |
>+           Describes the output shaper for a @group operation
>+           Differently from @inputs and @shaper allow specifying
>+           the shaper parent handle, too.
>+
>+      -
>+        name: shaper
>+        type: nest
>+        nested-attributes: ns-info
>+        doc: |
>+           Describes a single shaper for a @set operation
>+  -
>+    name: handle
>+    subset-of: net-shaper
>+    attributes:
>+      -
>+        name: scope
>+      -
>+        name: id
>+  -
>+    name: ns-info
>+    subset-of: net-shaper
>+    attributes:
>+      -
>+        name: handle
>+      -
>+        name: metric
>+      -
>+        name: bw-min
>+      -
>+        name: bw-max
>+      -
>+        name: burst
>+      -
>+        name: priority
>+      -
>+        name: weight
>+  -
>+    name: ns-output-info
>+    subset-of: net-shaper
>+    attributes:
>+      -
>+        name: parent
>+      -
>+        name: handle
>+      -
>+        name: metric
>+      -
>+        name: bw-min
>+      -
>+        name: bw-max
>+      -
>+        name: burst
>+      -
>+        name: priority
>+      -
>+        name: weight
>+

[...]