netdev - Re: [PATCH bpf-next v2 01/10] selftests/bpf: Adapt OUTPUT appending logic to lower versions of Make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzaW6UfJGFK5hy5JQYsf3qwiqQ81h4Awtkj3XtKv-HKRrA@mail.gmail.com>
Date: Wed, 4 Sep 2024 11:49:15 -0700
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: Pu Lehui <pulehui@...weicloud.com>, Eduard Zingerman <eddyz87@...il.com>
Cc: bpf@...r.kernel.org, linux-riscv@...ts.infradead.org, 
	netdev@...r.kernel.org, Andrii Nakryiko <andrii@...nel.org>, Mykola Lysenko <mykolal@...com>, 
	Björn Töpel <bjorn@...nel.org>, 
	Puranjay Mohan <puranjay@...nel.org>, Alexei Starovoitov <ast@...nel.org>, 
	Daniel Borkmann <daniel@...earbox.net>, Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>, 
	Yonghong Song <yonghong.song@...ux.dev>, John Fastabend <john.fastabend@...il.com>, 
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>, 
	Jiri Olsa <jolsa@...nel.org>, Palmer Dabbelt <palmer@...belt.com>, Pu Lehui <pulehui@...wei.com>
Subject: Re: [PATCH bpf-next v2 01/10] selftests/bpf: Adapt OUTPUT appending
 logic to lower versions of Make

On Wed, Sep 4, 2024 at 7:17 AM Pu Lehui <pulehui@...weicloud.com> wrote:
>
> From: Pu Lehui <pulehui@...wei.com>
>
> The $(let ...) function is only supported by GNU Make version 4.4 [0]

Eduard, seems like the mystery is finally solved.

We were actually considering removing the FEATURE-DUMP functionality
from BPF selftests, but it's good to have a fix nevertheless, thanks!

> and above, otherwise the following exception file or directory will be
> generated:
>
>         tools/testing/selftests/bpfFEATURE-DUMP.selftests
>         tools/testing/selftests/bpffeature/
>
> Considering that the GNU Make version of most Linux distributions is
> lower than 4.4, let us adapt the corresponding logic to it.
>
> Link: https://lists.gnu.org/archive/html/info-gnu/2022-10/msg00008.html [0]
> Signed-off-by: Pu Lehui <pulehui@...wei.com>
> ---
>  tools/testing/selftests/bpf/Makefile | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index 7660d19b66c2..9905e3739dd0 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
> @@ -187,8 +187,14 @@ FEATURE_TESTS := llvm
>  FEATURE_DISPLAY := $(FEATURE_TESTS)
>
>  # Makefile.feature expects OUTPUT to end with a slash
> +ifeq ($(shell expr $(MAKE_VERSION) \>= 4.4), 1)
>  $(let OUTPUT,$(OUTPUT)/,\
>         $(eval include ../../../build/Makefile.feature))
> +else
> +OUTPUT := $(OUTPUT)/
> +$(eval include ../../../build/Makefile.feature)
> +OUTPUT := $(patsubst %/,%,$(OUTPUT))
> +endif
>  endif
>
>  ifeq ($(feature-llvm),1)
> --
> 2.34.1
>