netdev - Re: [PATCH bpf-next v2 01/10] selftests/bpf: Adapt OUTPUT appending logic to lower versions of Make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19101f0b4dbbc933e59ce545bb9f5d719c4e5024.camel@gmail.com>
Date: Wed, 04 Sep 2024 12:29:33 -0700
From: Eduard Zingerman <eddyz87@...il.com>
To: Andrii Nakryiko <andrii.nakryiko@...il.com>, Pu Lehui
	 <pulehui@...weicloud.com>
Cc: bpf@...r.kernel.org, linux-riscv@...ts.infradead.org, 
 netdev@...r.kernel.org, Andrii Nakryiko <andrii@...nel.org>, Mykola Lysenko
 <mykolal@...com>, Björn Töpel <bjorn@...nel.org>, 
 Puranjay Mohan <puranjay@...nel.org>, Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>,  Martin KaFai Lau
 <martin.lau@...ux.dev>, Song Liu <song@...nel.org>, Yonghong Song
 <yonghong.song@...ux.dev>, John Fastabend <john.fastabend@...il.com>, KP
 Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, Hao Luo
 <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,  Palmer Dabbelt
 <palmer@...belt.com>, Pu Lehui <pulehui@...wei.com>
Subject: Re: [PATCH bpf-next v2 01/10] selftests/bpf: Adapt OUTPUT appending
 logic to lower versions of Make

On Wed, 2024-09-04 at 11:49 -0700, Andrii Nakryiko wrote:
> On Wed, Sep 4, 2024 at 7:17 AM Pu Lehui <pulehui@...weicloud.com> wrote:
> > 
> > From: Pu Lehui <pulehui@...wei.com>
> > 
> > The $(let ...) function is only supported by GNU Make version 4.4 [0]
> 
> Eduard, seems like the mystery is finally solved.

That this thing was silently ignored is most perplexing.

> We were actually considering removing the FEATURE-DUMP functionality
> from BPF selftests, but it's good to have a fix nevertheless, thanks!

Pu, thank you for figuring this out...

Acked-by: Eduard Zingerman <eddyz87@...il.com>