netdev - Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix memleak in ice_init_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <08298ba9-5f18-4eb9-a6a3-6e7410d8c4f0@intel.com>
Date: Wed, 4 Sep 2024 12:28:12 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>, Tony Nguyen <anthony.l.nguyen@...el.com>
CC: <netdev@...r.kernel.org>, Larysa Zaremba <larysa.zaremba@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix memleak in
 ice_init_tx_topology()



On 9/4/2024 5:32 AM, Przemek Kitszel wrote:
>  	dev = ice_pf_to_dev(pf);
> -	/* ice_cfg_tx_topo buf argument is not a constant,
> -	 * so we have to make a copy
> -	 */
> -	buf_copy = kmemdup(firmware->data, firmware->size, GFP_KERNEL);
> -
> -	err = ice_cfg_tx_topo(hw, buf_copy, firmware->size);
> +	err = ice_cfg_tx_topo(hw, (void *)firmware->data, firmware->size);
>  	if (!err) {

Yea, just casting away the const is sufficient here, the function
doesn't modify this buffer.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>