netdev - Re: [PATCH net-next] ice: Make use of assign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd42c1fd-c98b-4eda-b75f-01df15934653@engleder-embedded.com>
Date: Wed, 4 Sep 2024 21:07:50 +0200
From: Gerhard Engleder <gerhard@...leder-embedded.com>
To: Hongbo Li <lihongbo22@...wei.com>, anthony.l.nguyen@...el.com
Cc: przemyslaw.kitszel@...el.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, intel-wired-lan@...ts.osuosl.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ice: Make use of assign_bit() API

On 02.09.24 15:14, Hongbo Li wrote:
> We have for some time the assign_bit() API to replace open coded
> 
>      if (foo)
>              set_bit(n, bar);
>      else
>              clear_bit(n, bar);
> 
> Use this API to clean the code. No functional change intended.
> 
> Signed-off-by: Hongbo Li <lihongbo22@...wei.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_main.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index 46d3c5a34d6a..e3ad91b3ba77 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -6522,8 +6522,7 @@ ice_set_features(struct net_device *netdev, netdev_features_t features)
>   	if (changed & NETIF_F_HW_TC) {
>   		bool ena = !!(features & NETIF_F_HW_TC);
>   
> -		ena ? set_bit(ICE_FLAG_CLS_FLOWER, pf->flags) :
> -		      clear_bit(ICE_FLAG_CLS_FLOWER, pf->flags);
> +		assign_bit(ICE_FLAG_CLS_FLOWER, pf->flags, ena);
>   	}
>   
>   	if (changed & NETIF_F_LOOPBACK)

Reviewed-by: Gerhard Engleder <gerhard@...leder-embedded.com>