netdev - Re: [PATCH net-next v2] net: mana: Improve mana_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <beffd557-7e58-4841-a930-03c271d243a2@engleder-embedded.com>
Date: Wed, 4 Sep 2024 21:05:21 +0200
From: Gerhard Engleder <gerhard@...leder-embedded.com>
To: Shradha Gupta <shradhagupta@...ux.microsoft.com>,
 linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org
Cc: "K. Y. Srinivasan" <kys@...rosoft.com>,
 Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>,
 Dexuan Cui <decui@...rosoft.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Long Li <longli@...rosoft.com>,
 Simon Horman <horms@...nel.org>, Konstantin Taranov
 <kotaranov@...rosoft.com>,
 Souradeep Chakrabarti <schakrabarti@...ux.microsoft.com>,
 Erick Archer <erick.archer@...look.com>,
 Pavan Chebbi <pavan.chebbi@...adcom.com>, Ahmed Zaki <ahmed.zaki@...el.com>,
 Colin Ian King <colin.i.king@...il.com>,
 Shradha Gupta <shradhagupta@...rosoft.com>
Subject: Re: [PATCH net-next v2] net: mana: Improve mana_set_channels() in low
 mem conditions

On 02.09.24 05:45, Shradha Gupta wrote:
> The mana_set_channels() function requires detaching the mana
> driver and reattaching it with changed channel values.
> During this operation if the system is low on memory, the reattach
> might fail, causing the network device being down.
> To avoid this we pre-allocate buffers at the beginning of set operation,
> to prevent complete network loss
> 
> Signed-off-by: Shradha Gupta <shradhagupta@...ux.microsoft.com>
> ---
>   Changes in v2
>   * Pass num_queues as argument in mana_pre_alloc_rxbufs()
> ---
>   drivers/net/ethernet/microsoft/mana/mana_en.c |  6 ++--
>   .../ethernet/microsoft/mana/mana_ethtool.c    | 28 ++++++++++---------
>   include/net/mana/mana.h                       |  2 +-
>   3 files changed, 19 insertions(+), 17 deletions(-)

Looks better now with the argument for the queue number.

Reviewed-by: Gerhard Engleder <gerhard@...leder-embedded.com>