netdev - Re: [PATCH v2] dt-bindings: can: convert tcan4x5x.txt to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e5693766-1a2d-4cd5-a1ff-ea1f0800e238@kernel.org>
Date: Thu, 28 Nov 2024 09:12:14 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sean Nyekjaer <sean@...nix.com>
Cc: Marc Kleine-Budde <mkl@...gutronix.de>,
 Vincent Mailhol <mailhol.vincent@...adoo.fr>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-can@...r.kernel.org,
 netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: can: convert tcan4x5x.txt to DT schema

On 06/11/2024 15:27, Krzysztof Kozlowski wrote:
> On 06/11/2024 15:24, Krzysztof Kozlowski wrote:
>> On Tue, Nov 05, 2024 at 03:24:34PM +0100, Sean Nyekjaer wrote:
>>> +  device-wake-gpios:
>>> +    description:
>>> +      Wake up GPIO to wake up the TCAN device.
>>> +      Not available with tcan4552/4553.
>>> +    maxItems: 1
>>> +
>>> +  bosch,mram-cfg:
>>
>> Last time I wrote:
>> "You need to mention all changes done to the binding in the commit msg."
>>
>> Then I wrote again:
>> "Yeah, CAREFULLY [read][//this was missing, added now] previous review
>> and respond to all comments or implement all of them (or any
>> combination). If you leave one comment ignored, it will mean reviewer
>> has to do same work twice. That's very discouraging and wasteful of my
>> time."
>>
>> Then I wrote:
>> "Where? I pointed out that this is a change. I cannot find it...."
>>
>> So we are back at the same spot but I waste much more time to respond
>> and repeat the same.
>>
>> You must address all comments: either respond, fix or ask for
>> clarifications. You cannot leave anything ignored.
>>
>> I am not going to review the rest.
> 
> Uh, I am wrong. You did remove the supplies, but I just looked at wrong
> version. Apologies, everything is fine and you did implement my
> feedback. Thank you.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

As pointed out recently, this is not correct conversion - it does not
match existing users. Conversion is supposed to lead to binding which
satisfies existing users - DTS and actual ABI - otherwise you produced
just incorrect schema.

Best regards,
Krzysztof