netdev - Re: [PATCH net-next] net/smc: Optimize the timing of unlocking in smc_listen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241130110425.4610e6b6@kernel.org>
Date: Sat, 30 Nov 2024 11:04:25 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: liqiang <liqiang64@...wei.com>
Cc: <wenjia@...ux.ibm.com>, <jaka@...ux.ibm.com>,
 <alibuda@...ux.alibaba.com>, <tonylu@...ux.alibaba.com>,
 <guwen@...ux.alibaba.com>, <linux-s390@...r.kernel.org>,
 <netdev@...r.kernel.org>, <luanjianhai@...wei.com>,
 <zhangxuzhou4@...wei.com>, <dengguangxing@...wei.com>,
 <gaochao24@...wei.com>
Subject: Re: [PATCH net-next] net/smc: Optimize the timing of unlocking in
 smc_listen_work

On Sat, 30 Nov 2024 16:26:30 +0800 liqiang wrote:
> The optimized code is equivalent to the original process, and it releases the
> lock early.

By a single clock cycle? You need to provide much more detailed
justification, otherwise this looks like churn for no real gain.
-- 
pw-bot: cr