netdev - Re: [PATCH net-next 2/2] enic: Obtain the Link speed only after the link comes up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250107214835.25987-1-johndale@cisco.com>
Date: Tue,  7 Jan 2025 13:48:35 -0800
From: John Daley <johndale@...co.com>
To: andrew@...n.ch
Cc: andrew+netdev@...n.ch,
	benve@...co.com,
	davem@...emloft.net,
	edumazet@...gle.com,
	johndale@...co.com,
	kuba@...nel.org,
	neescoba@...co.com,
	netdev@...r.kernel.org,
	pabeni@...hat.com,
	satishkh@...co.com
Subject: Re: [PATCH net-next 2/2] enic: Obtain the Link speed only after the link comes up

>> The link speed is obtained in the RX adaptive coalescing function. It
>> was being called at probe time when the link may not be up. Change the
>> call to run after the Link comes up.
>> 
>> The impact of not getting the correct link speed was that the low end of
>> the adaptive interrupt range was always being set to 0 which could have
>> caused a slight increase in the number of RX interrupts.
>> 
>> Co-developed-by: Nelson Escobar <neescoba@...co.com>
>> Signed-off-by: Nelson Escobar <neescoba@...co.com>
>> Co-developed-by: Satish Kharat <satishkh@...co.com>
>> Signed-off-by: Satish Kharat <satishkh@...co.com>
>> Signed-off-by: John Daley <johndale@...co.com>
>> ---
>>  drivers/net/ethernet/cisco/enic/enic_main.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
>> index 957efe73e41a..49f6cab01ed5 100644
>> --- a/drivers/net/ethernet/cisco/enic/enic_main.c
>> +++ b/drivers/net/ethernet/cisco/enic/enic_main.c
>> @@ -109,7 +109,7 @@ static struct enic_intr_mod_table mod_table[ENIC_MAX_COALESCE_TIMERS + 1] = {
>>  static struct enic_intr_mod_range mod_range[ENIC_MAX_LINK_SPEEDS] = {
>>  	{0,  0}, /* 0  - 4  Gbps */
>>  	{0,  3}, /* 4  - 10 Gbps */
>> -	{3,  6}, /* 10 - 40 Gbps */
>> +	{3,  6}, /* 10+ Gbps */
>>  };
>
>So we still have this second change, which is not explained in the
>commit message, and probably should be in a patch of its own.

OK, I did a v2 with the typo fix as its own patch in this set of link related
patches. Thanks.