netdev - Re: [PATCH net-next 2/2] enic: Obtain the Link speed only after the link comes up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z34UgXz6ota8D27W@mev-dev.igk.intel.com>
Date: Wed, 8 Jan 2025 07:00:51 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: John Daley <johndale@...co.com>
Cc: andrew+netdev@...n.ch, benve@...co.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, neescoba@...co.com,
	netdev@...r.kernel.org, pabeni@...hat.com, satishkh@...co.com
Subject: Re: [PATCH net-next 2/2] enic: Obtain the Link speed only after the
 link comes up

On Tue, Jan 07, 2025 at 11:53:04AM -0800, John Daley wrote:
> >> diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
> >> index 957efe73e41a..49f6cab01ed5 100644
> >> --- a/drivers/net/ethernet/cisco/enic/enic_main.c
> >> +++ b/drivers/net/ethernet/cisco/enic/enic_main.c
> >> @@ -109,7 +109,7 @@ static struct enic_intr_mod_table mod_table[ENIC_MAX_COALESCE_TIMERS + 1] = {
> >>  static struct enic_intr_mod_range mod_range[ENIC_MAX_LINK_SPEEDS] = {
> >>  	{0,  0}, /* 0  - 4  Gbps */
> >>  	{0,  3}, /* 4  - 10 Gbps */
> >> -	{3,  6}, /* 10 - 40 Gbps */
> >> +	{3,  6}, /* 10+ Gbps */
> >
> >Is this on purpose? You didn't mention anything about speed range in
> >commit message. Just wondering, patch looks fine, thanks.
> 
> I changed the comment on purpose since it applies to adapters way past
> 40 Gbps nowdays. I should have mentioned the change. Thanks for the
> reveiw.

Reasonable, thanks

> >
> >Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>