netdev - Re: [PATCH net-next 1/5] net: report csum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6umY6t_ART7PdL8@LQ3V64L9R2>
Date: Tue, 11 Feb 2025 11:34:59 -0800
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, alexanderduyck@...com, netdev@...r.kernel.org,
	edumazet@...gle.com, pabeni@...hat.com, andrew+netdev@...n.ch,
	horms@...nel.org
Subject: Re: [PATCH net-next 1/5] net: report csum_complete via qstats

On Tue, Feb 11, 2025 at 10:13:52AM -0800, Jakub Kicinski wrote:
> Commit 13c7c941e729 ("netdev: add qstat for csum complete") reserved
> the entry for csum complete in the qstats uAPI. Start reporting this
> value now that we have a driver which needs it.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: jdamato@...tly.com
> ---
>  include/net/netdev_queues.h | 1 +
>  net/core/netdev-genl.c      | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/include/net/netdev_queues.h b/include/net/netdev_queues.h
> index 73d3401261a6..825141d675e5 100644
> --- a/include/net/netdev_queues.h
> +++ b/include/net/netdev_queues.h
> @@ -23,6 +23,7 @@ struct netdev_queue_stats_rx {
>  	u64 hw_drops;
>  	u64 hw_drop_overruns;
>  
> +	u64 csum_complete;
>  	u64 csum_unnecessary;
>  	u64 csum_none;
>  	u64 csum_bad;
> diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c
> index 0dcd4faefd8d..c18bb53d13fd 100644
> --- a/net/core/netdev-genl.c
> +++ b/net/core/netdev-genl.c
> @@ -581,6 +581,7 @@ netdev_nl_stats_write_rx(struct sk_buff *rsp, struct netdev_queue_stats_rx *rx)
>  	    netdev_stat_put(rsp, NETDEV_A_QSTATS_RX_ALLOC_FAIL, rx->alloc_fail) ||
>  	    netdev_stat_put(rsp, NETDEV_A_QSTATS_RX_HW_DROPS, rx->hw_drops) ||
>  	    netdev_stat_put(rsp, NETDEV_A_QSTATS_RX_HW_DROP_OVERRUNS, rx->hw_drop_overruns) ||
> +	    netdev_stat_put(rsp, NETDEV_A_QSTATS_RX_CSUM_COMPLETE, rx->csum_complete) ||
>  	    netdev_stat_put(rsp, NETDEV_A_QSTATS_RX_CSUM_UNNECESSARY, rx->csum_unnecessary) ||
>  	    netdev_stat_put(rsp, NETDEV_A_QSTATS_RX_CSUM_NONE, rx->csum_none) ||
>  	    netdev_stat_put(rsp, NETDEV_A_QSTATS_RX_CSUM_BAD, rx->csum_bad) ||

Reviewed-by: Joe Damato <jdamato@...tly.com>