netdev - Re: [PATCH net-next 2/5] eth: fbnic: wrap tx queue stats in a struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6un1GD15zX5-104@LQ3V64L9R2>
Date: Tue, 11 Feb 2025 11:41:08 -0800
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, alexanderduyck@...com, netdev@...r.kernel.org,
	edumazet@...gle.com, pabeni@...hat.com, andrew+netdev@...n.ch,
	horms@...nel.org
Subject: Re: [PATCH net-next 2/5] eth: fbnic: wrap tx queue stats in a struct

On Tue, Feb 11, 2025 at 10:13:53AM -0800, Jakub Kicinski wrote:
> The queue stats struct is used for Rx and Tx queues. Wrap
> the Tx stats in a struct and a union, so that we can reuse
> the same space for Rx stats on Rx queues.
> 
> This also makes it easy to add an assert to the stat handling
> code to catch new stats not being aggregated on shutdown.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  drivers/net/ethernet/meta/fbnic/fbnic_txrx.h    |  8 ++++++--
>  drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c |  8 ++++----
>  drivers/net/ethernet/meta/fbnic/fbnic_txrx.c    | 10 ++++++----
>  3 files changed, 16 insertions(+), 10 deletions(-)

Read through the driver and changes look good to me. Since I don't
have an fbnic or a lot of familiarity with the driver, I'll provide
a more modest:

Acked-by: Joe Damato <jdamato@...tly.com>