netdev - Re: [PATCH net-next 1/4] eth: mlx4: create a page pool for Rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250211114428.6dc9c7e3@kernel.org>
Date: Tue, 11 Feb 2025 11:44:28 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Tariq Toukan <ttoukan.linux@...il.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 tariqt@...dia.com, hawk@...nel.org
Subject: Re: [PATCH net-next 1/4] eth: mlx4: create a page pool for Rx

On Tue, 11 Feb 2025 21:18:46 +0200 Tariq Toukan wrote:
> > -	if (xdp_rxq_info_reg(&ring->xdp_rxq, priv->dev, queue_index, 0) < 0)
> > +	pp.flags = PP_FLAG_DMA_MAP;
> > +	pp.pool_size = MLX4_EN_MAX_RX_SIZE;
> > +	pp.nid = node;
> > +	pp.napi = &priv->rx_cq[queue_index]->napi;
> > +	pp.netdev = priv->dev;
> > +	pp.dev = &mdev->dev->persist->pdev->dev;
> > +	pp.dma_dir = DMA_BIDIRECTIONAL;  
> 
> I just noticed one more thing, here we better take the value from 
> priv->dma_dir, as it could be DMA_FROM_DEVICE or DMA_BIDIRECTIONAL 
> depending on XDP program presence.

ack!