netdev - Re: [PATCH net-next 1/4] eth: mlx4: create a page pool for Rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <634d145e-52d8-4c29-affc-f4233c28d322@gmail.com>
Date: Tue, 11 Feb 2025 21:38:16 +0200
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 tariqt@...dia.com, hawk@...nel.org
Subject: Re: [PATCH net-next 1/4] eth: mlx4: create a page pool for Rx



On 11/02/2025 21:23, Jakub Kicinski wrote:
> On Tue, 11 Feb 2025 21:21:13 +0200 Tariq Toukan wrote:
>>>> The ring size is in *pages*. Frag is also somewhat irrelevant, given
>>>> that we're talking about full pages here, not 2k frags. So I think
>>>> I'll go with:
>>>>
>>>>      pp.pool_size =
>>>>          size * DIV_ROUND_UP(MLX4_EN_EFF_MTU(dev->mtu), PAGE_SIZE);
>>>    
>>
>> Can use priv->rx_skb_size as well, it hosts the eff mtu value.
> 
> Missed this before hitting send, I'll repost tomorrow, I guess.

Sorry for posting them a bit late.

This one is a nit, I want to make sure you noticed my other comment 
regarding pp.dma_dir.