netdev - Re: [PATCH net] net: txgbe: fix memory leak in txgbe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250416152357.GS395307@horms.kernel.org>
Date: Wed, 16 Apr 2025 16:23:57 +0100
From: Simon Horman <horms@...nel.org>
To: Abdun Nihaal <abdun.nihaal@...il.com>
Cc: jiawenwu@...stnetic.com, mengyuanlou@...-swift.com,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: txgbe: fix memory leak in txgbe_probe() error
 path

On Tue, Apr 15, 2025 at 08:59:09AM +0530, Abdun Nihaal wrote:
> When txgbe_sw_init() is called, memory is allocated for wx->rss_key
> in wx_init_rss_key(). However, in txgbe_probe() function, the subsequent
> error paths after txgbe_sw_init() don't free the rss_key. Fix that by
> freeing it in error path along with wx->mac_table.
> 
> Also change the label to which execution jumps when txgbe_sw_init()
> fails, because otherwise, it could lead to a double free for rss_key,
> when the mac_table allocation fails in wx_sw_init().
> 
> Fixes: 937d46ecc5f9 ("net: wangxun: add ethtool_ops for channel number")
> Reported-by: Jiawen Wu <jiawenwu@...stnetic.com>
> Signed-off-by: Abdun Nihaal <abdun.nihaal@...il.com>

Reviewed-by: Simon Horman <horms@...nel.org>