netdev - Re: [PATCH RESEND v2 net-next 14/14] ipv6: Get rid of RTNL for SIOCADDRT and RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77c438b9-2186-49f4-b95b-5e2df61a573b@redhat.com>
Date: Wed, 16 Apr 2025 17:26:49 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>,
 "David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>
Cc: Simon Horman <horms@...nel.org>, Kuniyuki Iwashima <kuni1840@...il.com>,
 netdev@...r.kernel.org
Subject: Re: [PATCH RESEND v2 net-next 14/14] ipv6: Get rid of RTNL for
 SIOCADDRT and RTM_NEWROUTE.

On 4/14/25 8:15 PM, Kuniyuki Iwashima wrote:
> @@ -5250,7 +5252,7 @@ static int rtm_to_fib6_config(struct sk_buff *skb, struct nlmsghdr *nlh,
>  		cfg->fc_encap_type = nla_get_u16(tb[RTA_ENCAP_TYPE]);
>  
>  		err = lwtunnel_valid_encap_type(cfg->fc_encap_type,
> -						extack, newroute);
> +						extack, false);

It looks every caller always pass 'false' as last argument to
lwtunnel_valid_encap_type(), so such argument could/should be dropped
(as a follow-up if this is too big)

Thanks,

Paolo