netdev - Re: [PATCH net] selftests: rtnetlink: fix addrlft test flakiness on power-saving systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250818190803.19a43fae@kernel.org>
Date: Mon, 18 Aug 2025 19:08:03 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, Shuah Khan <shuah@...nel.org>,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net] selftests: rtnetlink: fix addrlft test flakiness on
 power-saving systems

On Tue, 19 Aug 2025 01:50:51 +0000 Hangbin Liu wrote:
> Hmm, I think we need to know what's the current preferred_lft and valid_lft
> on failed test. Would you please add a debug line so we can get the info
> after failed?
> 
>         slowwait 5 check_addr_not_exist "$devdummy" "10.23.11."
>         if [ $? -eq 1 ]; then
> +               ip addr show dev "$devdummy"
>                 check_err 1
>                 end_test "FAIL: preferred_lft addresses remaining"
>                 return

Given that this is 2nd or 3rd time we're massaging this test case 
I think we should just add the appropriate debug information to the
test itself. Please post a real patch?