netdev - Re: [net-next 1/6] net: rswitch: Move definition of S4 gPTP offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250916122029.GC1045278@ragnatech.se>
Date: Tue, 16 Sep 2025 14:20:29 +0200
From: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
To: Andrew Lunn <andrew@...n.ch>
Cc: Paul Barker <paul@...rker.dev>, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Magnus Damm <magnus.damm@...il.com>,
	Richard Cochran <richardcochran@...il.com>, netdev@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org
Subject: Re: [net-next 1/6] net: rswitch: Move definition of S4 gPTP offset

On 2025-09-16 14:16:09 +0200, Andrew Lunn wrote:
> On Tue, Sep 16, 2025 at 12:10:50PM +0200, Niklas Söderlund wrote:
> > The files rcar_gen4_ptp.{c,h} implements an abstraction of the gPTP
> > support implemented together with different other IP blocks. The first
> > device added which supported this was RSWITCH on R-Car S4.
> > 
> > While doing so the RSWITCH R-Car S4 specific offset was added to the
> > generic Gen4 gPTP header file. Move it to the RSWITCH driver to make it
> > clear it only applies to this driver.
> 
> This is a nice simple patch to understand, which is good. But i do
> wounder about naming schemes. Since this is a RSWITCH define, should
> it use the RSWITCH_ prefix? 

It could, I opted for the least disruptive path and just moved it as is.  
Would you prefers I rename?

> 
> Are there other implementations which have an equivalent of
> RCAR_GEN4_GPTP_OFFSET_S4? How are they named?

There are none, at least not so far as the RSWITCH IP are only available 
on the R-Car S4 SoC.

> 
> 	Andrew

-- 
Kind Regards,
Niklas Söderlund