netdev - Re: [PATCH net-next v12 0/5] Add Ethernet MAC support for SpacemiT K1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250916122026-GYB1255161@gentoo.org>
Date: Tue, 16 Sep 2025 20:20:26 +0800
From: Yixun Lan <dlan@...too.org>
To: pabeni@...hat.com
Cc: Vivian Wang <wangruikang@...as.ac.cn>, andrew+netdev@...n.ch,
	kuba@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, p.zabel@...gutronix.de, paul.walmsley@...ive.com,
	palmer@...belt.com, aou@...s.berkeley.edu, alex@...ti.fr,
	uwu@...m.page, vadim.fedorenko@...ux.dev, junhui.liu@...moral.tech,
	horms@...nel.org, maxime.chevallier@...tlin.com,
	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev,
	linux-kernel@...r.kernel.org, conor.dooley@...rochip.com,
	troy.mitchell@...ux.spacemit.com, hendrik.hamerlinck@...mernet.be,
	andrew@...n.ch
Subject: Re: [PATCH net-next v12 0/5] Add Ethernet MAC support for SpacemiT K1

Hi Paolo Abeni,

Thanks for taking this series, but I have one comment (see below)

On 11:20 Tue 16 Sep     , patchwork-bot+netdevbpf@...nel.org wrote:
> Hello:
> 
> This series was applied to netdev/net-next.git (main)
> by Paolo Abeni <pabeni@...hat.com>:
> 
> On Sun, 14 Sep 2025 12:23:11 +0800 you wrote:
> > SpacemiT K1 has two gigabit Ethernet MACs with RGMII and RMII support.
> > Add devicetree bindings, driver, and DTS for it.
> > 
> > Tested primarily on BananaPi BPI-F3. Basic TX/RX functionality also
> > tested on Milk-V Jupiter.
> > 
> > I would like to note that even though some bit field names superficially
> > resemble that of DesignWare MAC, all other differences point to it in
> > fact being a custom design.
> > 
> > [...]
> 
> Here is the summary with links:
>   - [net-next,v12,1/5] dt-bindings: net: Add support for SpacemiT K1
>     https://git.kernel.org/netdev/net-next/c/62a12a221769
>   - [net-next,v12,2/5] net: spacemit: Add K1 Ethernet MAC
>     https://git.kernel.org/netdev/net-next/c/bfec6d7f2001
..
>   - [net-next,v12,3/5] riscv: dts: spacemit: Add Ethernet support for K1
>     https://git.kernel.org/netdev/net-next/c/60775f28cfb7
>   - [net-next,v12,4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3
>     https://git.kernel.org/netdev/net-next/c/3c247a6366d5
>   - [net-next,v12,5/5] riscv: dts: spacemit: Add Ethernet support for Jupiter
>     https://git.kernel.org/netdev/net-next/c/e32dc7a936b1
> 

Generally, I'd expect the DT part patch (3-5) to go via SpacemiT's SoC tree[1],
so, this will avoid potential conflicts..

Can you drop patch 3-5? then I will take care of them, plus there is one more
patch in my queue..

Link: https://github.com/spacemit-com/linux/tree/k1/dt-for-next [1]

-- 
Yixun Lan (dlan)