netdev - Re: [net-next 2/6] net: rcar_gen4_ptp: Move control fields to users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52a331b3-275e-4a7c-8852-875e8d5b8f62@lunn.ch>
Date: Tue, 16 Sep 2025 14:22:18 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
Cc: Paul Barker <paul@...rker.dev>, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Magnus Damm <magnus.damm@...il.com>,
	Richard Cochran <richardcochran@...il.com>, netdev@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org
Subject: Re: [net-next 2/6] net: rcar_gen4_ptp: Move control fields to users

On Tue, Sep 16, 2025 at 12:10:51PM +0200, Niklas Söderlund wrote:
> The struct rcar_gen4_ptp_private provides two fields for convenience of
> its users, tstamp_tx_ctrl and tstamp_rx_ctrl. These fields are not used
> by the rcar_gen4_ptp driver itself but only by the drivers using it.
> 
> Upcoming work will enable the RAVB driver currently only supporting gPTP
> on pre-Gen4 SoCs to use the Gen4 implementation as well. To facilitate
> this the convenience of having these fields in struct
> rcar_gen4_ptp_private becomes a problem as the RAVB driver already have
> it's own driver specific fields for the same thing.
> 
> Move the fields from struct rcar_gen4_ptp_private to each driver using
> the Gen4 gPTP clocks own private data structures. There is no functional
> change.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew