netdev - Re: [RFC mm v5 1/2] page_pool: check nmdesc->pp to see its usage as page pool for net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <785c9d27-23e7-4ecf-ad2e-202ba506f2e0@gmail.com>
Date: Thu, 6 Nov 2025 11:07:58 +0000
From: Pavel Begunkov <asml.silence@...il.com>
To: Byungchul Park <byungchul@...com>, linux-mm@...ck.org,
 netdev@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, kernel_team@...ynix.com,
 harry.yoo@...cle.com, ast@...nel.org, daniel@...earbox.net,
 davem@...emloft.net, kuba@...nel.org, hawk@...nel.org,
 john.fastabend@...il.com, sdf@...ichev.me, saeedm@...dia.com,
 leon@...nel.org, tariqt@...dia.com, mbloch@...dia.com,
 andrew+netdev@...n.ch, edumazet@...gle.com, pabeni@...hat.com,
 akpm@...ux-foundation.org, david@...hat.com, lorenzo.stoakes@...cle.com,
 Liam.Howlett@...cle.com, vbabka@...e.cz, rppt@...nel.org, surenb@...gle.com,
 mhocko@...e.com, horms@...nel.org, jackmanb@...gle.com, hannes@...xchg.org,
 ziy@...dia.com, ilias.apalodimas@...aro.org, willy@...radead.org,
 brauner@...nel.org, kas@...nel.org, yuzhao@...gle.com,
 usamaarif642@...il.com, baolin.wang@...ux.alibaba.com,
 almasrymina@...gle.com, toke@...hat.com, bpf@...r.kernel.org,
 linux-rdma@...r.kernel.org, sfr@...b.auug.org.au, dw@...idwei.uk,
 ap420073@...il.com, dtatulea@...dia.com
Subject: Re: [RFC mm v5 1/2] page_pool: check nmdesc->pp to see its usage as
 page pool for net_iov not page-backed

On 11/3/25 07:51, Byungchul Park wrote:
> Currently, the condition 'page->pp_magic == PP_SIGNATURE' is used to
> determine if a page belongs to a page pool.  However, with the planned
> removal of ->pp_magic, we will instead leverage the page_type in struct
> page, such as PGTY_netpp, for this purpose.
> 
> That works for page-backed network memory.  However, for net_iov not
> page-backed, the identification cannot be based on the page_type.
> Instead, nmdesc->pp can be used to see if it belongs to a page pool, by
> making sure nmdesc->pp is NULL otherwise.
> 
> For net_iov not page-backed, initialize it using nmdesc->pp = NULL in
> net_devmem_bind_dmabuf() and using kvmalloc_array(__GFP_ZERO) in
> io_zcrx_create_area() so that netmem_is_pp() can check if nmdesc->pp is
> !NULL to confirm its usage as page pool.

Reviewed-by: Pavel Begunkov <asml.silence@...il.com>

-- 
Pavel Begunkov