netdev - Re: [EXTERNAL] [PATCH net-next v2] net: ti: icssg: Remove dedicated workqueue for ndo_set_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ec089e4-9721-4c55-a90e-a26630ecd91b@ti.com>
Date: Thu, 5 Feb 2026 18:55:16 +0530
From: Meghana Malladi <m-malladi@...com>
To: Kevin Hao <haokexin@...il.com>, <netdev@...r.kernel.org>
CC: MD Danish Anwar <danishanwar@...com>, Roger Quadros <rogerq@...nel.org>,
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, Jacob Keller <jacob.e.keller@...el.com>, "Vadim
 Fedorenko" <vadim.fedorenko@...ux.dev>, Himanshu Mittal <h-mittal1@...com>,
	Simon Horman <horms@...nel.org>, Byungchul Park <byungchul@...com>, "Markus
 Elfring" <elfring@...rs.sourceforge.net>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [EXTERNAL] [PATCH net-next v2] net: ti: icssg: Remove dedicated
 workqueue for ndo_set_rx_mode callback



On 2/5/26 11:55, Kevin Hao wrote:
> Currently, both the icssg-prueth and icssg-prueth-sr1 drivers create a 
> dedicated 'emac->cmd_wq' workqueue. In the icssg-prueth-sr1 driver, this 
> workqueue is not utilized at all. In the icssg-prueth driver, the 
> workqueue is only used to execute
> ZjQcmQRYFpfptBannerStart
> This message was sent from outside of Texas Instruments.
> Do not click links or open attachments unless you recognize the source 
> of this email and know the content is safe.
> Report Suspicious
> <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK! 
> uxdqXRfPtm1bKqXPFrvrtjTYQ8PpETcsXm4BwzS8mboFbVY11ssua4wfTbejgHbxjjWn8Pd03T8mRUc-C2Ywijhr0alXjcHhfRE3zQch7w8HkSQ$>
> ZjQcmQRYFpfptBannerEnd
> 
> Currently, both the icssg-prueth and icssg-prueth-sr1 drivers create
> a dedicated 'emac->cmd_wq' workqueue.
> 
> In the icssg-prueth-sr1 driver, this workqueue is not utilized at all.
> 
> In the icssg-prueth driver, the workqueue is only used to execute the
> actual processing of ndo_set_rx_mode. However, creating a dedicated
> workqueue for such a simple use case is unnecessary. To simplify the
> code, switch to using the system default workqueue instead.
> 
> Signed-off-by: Kevin Hao <haokexin@...il.com>
> ---
> While addressing an issue in the cpsw driver, I based my fix [1] on the
> implementation of the emac_ndo_set_rx_mode() function in icssg. During review,
> Jakub pointed out that the dedicated workqueue for the ndo_set_rx_mode
> callback might be unnecessary [2]. I subsequently used the system workqueue for
> this purpose in the cpsw driver, and it performed as expected. Therefore,
> I believe the same approach can be applied to the icssg driver. This
> patch aim to remove this dedicated workqueue for icssg drivers.
> 
> Please note: I do not have access to a board that supports the CSSG PRU
> Ethernet controller, so this change has only been build-tested.

Based on the changes I have multicast and promiscuous modes.
logs: 
https://gist.github.com/MeghanaMalladiTI/9598b33848344027772a5bf759b1bb8e

Tested-by: Meghana Malladi <m-malladi@...com>