[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080326000930.GB18701@infradead.org>
Date: Tue, 25 Mar 2008 20:09:30 -0400
From: Christoph Hellwig <hch@...radead.org>
To: Andi Kleen <andi@...stfloor.org>
Cc: Jack Steiner <steiner@....com>, mingo@...e.hu, tglx@...utronix.de,
linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC 6/8] x86_64: Define the macros and tables for the basic
UV infrastructure.
On Tue, Mar 25, 2008 at 11:11:11AM +0100, Andi Kleen wrote:
> Not sure what physical mode is.
>
> > +#ifdef __BIOS__
> > +#define UV_ADDR(x) ((unsigned long *)(x))
> > +#else
> > +#define UV_ADDR(x) ((unsigned long *)__va(x))
> > +#endif
>
> But it it would be cleaner if your BIOS just supplied a suitable __va()
> and then you remove these macros.
the bios should just have headers of it's own instead of placing this
burden on kernel code.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists