linux-kernel - Re: [PATCH 8/9] arch/powerpc/kernel: Drop unnecessary null test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTi=yOJ0Zfsn_h_xWai5O=OPkccMb-hDwKK+dWZwf@mail.gmail.com>
Date:	Tue, 3 Aug 2010 16:00:25 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Dan Carpenter <error27@...il.com>, Julia Lawall <julia@...u.dk>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 8/9] arch/powerpc/kernel: Drop unnecessary null test

On Tue, Aug 3, 2010 at 3:51 PM, Dan Carpenter <error27@...il.com> wrote:
> On Tue, Aug 03, 2010 at 11:35:17PM +0200, Julia Lawall wrote:
>> diff --git a/arch/powerpc/kernel/pci_of_scan.c b/arch/powerpc/kernel/pci_of_scan.c
>> index 6ddb795..62dd363 100644
>> --- a/arch/powerpc/kernel/pci_of_scan.c
>> +++ b/arch/powerpc/kernel/pci_of_scan.c
>> @@ -336,8 +336,7 @@ static void __devinit __of_scan_bus(struct device_node *node,
>>               if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE ||
>>                   dev->hdr_type == PCI_HEADER_TYPE_CARDBUS) {
>>                       struct device_node *child = pci_device_to_OF_node(dev);
>> -                     if (dev)
>> -                             of_scan_pci_bridge(child, dev);
>> +                     of_scan_pci_bridge(child, dev);
>
> The intention was probably to check "child" instead of "dev".
> pci_device_to_OF_node() can return NULL.  On the other hand the code
> has been this way for a year and no one has complained...

Still, it should be fixed.  It is likely that I'll be generalizing
this code for other architectures in the near future.  I'll spin a
patch.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/