linux-kernel - Re: [PATCH 3/3] ARM: edma: Split up header file to platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 08 Dec 2014 14:16:59 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Vinod Koul <vinod.koul@...el.com>
Cc:	Peter Ujfalusi <peter.ujfalusi@...com>,
	Mark Brown <broonie@...nel.org>, linux@....linux.org.uk,
	nsekhar@...com, khilman@...prootsystems.com,
	Liam Girdwood <lgirdwood@...il.com>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	ulf.hansson@...aro.org, chris@...ntf.net,
	linux-arm-kernel@...ts.infradead.org, linux-mmc@...r.kernel.org,
	linux-spi@...r.kernel.org, linux-omap@...r.kernel.org,
	Tony Lindgren <tony@...mide.com>, dmaengine@...r.kernel.org
Subject: Re: [PATCH 3/3] ARM: edma: Split up header file to platform_data and API file

On Monday 08 December 2014 18:19:17 Vinod Koul wrote:
> On Thu, Nov 27, 2014 at 12:41:31PM +0200, Peter Ujfalusi wrote:
> > include/linux/platform_data/ is not a correct place to keep the API
> > definitions for edma, it is meant to be only for the pdata for the device.
> > Clean up this by moving the API to include/linux/edma.h
> > 
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> > ---
> >  arch/arm/common/edma.c                     |   3 +-
> >  arch/arm/mach-davinci/devices.c            |   1 +
> >  arch/arm/mach-davinci/include/mach/da8xx.h |   1 +
> >  drivers/dma/edma.c                         |   2 +-
> >  include/linux/edma.h                       | 153 +++++++++++++++++++++++++++++
> >  include/linux/platform_data/edma.h         | 148 ++--------------------------
> >  sound/soc/davinci/davinci-pcm.h            |   1 +
> >  7 files changed, 165 insertions(+), 144 deletions(-)
> >  create mode 100644 include/linux/edma.h
> I was hoping that this will have delete for platform_data/edma.h, do we
> still need that and why shouldn't we get rid of this 

I think the platform_data/edma.h file is needed for as long as we have
mach-davinci systems that are not converted to boot using DT. At the current
pace of development in that area, I would expect that to take a few more
years at least: da850 support is slowly proceeding (since 2012), da830 should
be fairly straightforward to add once da850 is done, but I haven't seen
anybody start working on the dm* socs for DT.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/